Skip to content

Make phpactor-action-open-file expect target #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2019
Merged

Make phpactor-action-open-file expect target #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion phpactor.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,11 +385,16 @@ of GitHub.")
(apply #'phpactor-action-dispatch (list :action (plist-get action :name) :parameters (plist-get action :parameters))))
actions))

(cl-defun phpactor-action-open-file (&key path offset force_reload)
(cl-defun phpactor-action-open-file (&key path offset force_reload target)
"Open file from Phpactor."
(unless (and path offset)
(user-error "Definition not found"))

;; TODO: Implement other target: Phpactor\Extension\Rpc\Response\OpenFileResponse
;; `target' expects "focused_window", "vsplit", "hsplit" and "new_tab"
(unless target
(setq target "focused_window"))

(if (fboundp 'xref-push-marker-stack)
(xref-push-marker-stack)
(with-no-warnings
Expand Down