Skip to content

Conversation

@MarkRedeman
Copy link
Contributor

This pull request adds the option to use the native JSON functionality available in Emacs 27.
I haven't yet done any benchmarks but I've seen some people mention that the native implementation can be 4 times as fast than json.el.

This code was mostly based on the lsp-mode's implementation, specifically serialize function is based on lsp-mode's lsp--make-message while the parse function is based on their lsp--read-json function.

Copy link
Member

@zonuexe zonuexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zonuexe zonuexe merged commit f5df770 into emacs-php:master May 31, 2019
@zonuexe
Copy link
Member

zonuexe commented May 31, 2019

@MarkRedeman Thank you for your contribution!

@MarkRedeman
Copy link
Contributor Author

Thanks for the quick merge!

@MarkRedeman MarkRedeman deleted the native-json-functionality branch May 31, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants