Skip to content

Add support for override_method #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Add support for override_method #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions phpactor.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,9 +277,9 @@ of GitHub.")
(error "Action cancelled")))
(file (read-file-name label nil default))
(text (read-string label default))
(choice (completing-read label
(cl-loop for (_ v) on choices by #'cddr
collect v)))
((choice list) (completing-read label
(cl-loop for (_ v) on choices by #'cddr
collect v)))
(t (error "Unknown input type %s" type)))))

(defun phpactor-action--collect-inputs (inputs)
Expand Down Expand Up @@ -822,5 +822,12 @@ function."
(let ((arguments (phpactor--command-argments :source :path :offset)))
(apply #'phpactor-action-dispatch (phpactor--rpc "change_visibility" arguments))))

;;;###autoload
(defun phpactor-override-method ()
"Execute Phpactor RPC override_method action."
(interactive)
(let ((arguments (phpactor--command-argments :source :path)))
(apply #'phpactor-action-dispatch (phpactor--rpc "override_method" arguments))))

(provide 'phpactor)
;;; phpactor.el ends here