Fix regression from pr #29 causing completion on object to fail

[kermorgant]

Sorry for last PR, it introduced a regression when completion occured on object methods...

This should hopefully fix that

[ejmr]

Thank you for catching the regression and correcting it. In my experience those things exist for way too long in too many open-source projects.

[kermorgant]

I've been using thix fix for some days now and I haven't observed any problem.

@zonuexe I'm tempted to merge this one as I can only see benefits with it. would you be ok for a merge ?

[ejmr]

The commit message has a typo and IMO should begin with "Fix..." instead of "fix...". That small comment aside though, I reviewed the code (it's a small change), and I will vouch for its quality and that it should be merged into PHP Mode.

[kermorgant]

As a side note, I've noticed a pull request which might be worth following in regard to how completion works with company-phpactor.

I've not checked personnally how it would change things, but I thought adding this comment might be useful in the future.

[kermorgant]

@ejmr are you suggesting to open a pull request directly for php-mode ?

[ejmr]

@kermorgant

...are you suggesting to open a pull request directly for php-mode?

No. I accidentally typed the wrong project name. Hilariously in a comment where I called you out on a typo, lol. I meant this change should be merged in phpactor.el.

[zonuexe]

@kermorgant LGTM

@zonuexe I'm tempted to merge this one as I can only see benefits with it. would you be ok for a merge?

You can merge such trivial bugs at your discretion. 👍

[zonuexe]

BTW, I had a serious problem in managing the issue / PR's reading and resolution, but I installed Jasper app today. I am trying to improve my response by that.