Keep plugin.json version in sync with release tags#17
Merged
Conversation
Add a make release VERSION=x.y.z target that validates the version, rewrites the version field in .claude-plugin/plugin.json, commits, and tags v$(VERSION). It refuses to run on a dirty tree or with a non-semver version. Add a verify-version job to the release workflow that gates GoReleaser: on a tag push it compares the tag against plugin.json and fails the release if they differ, so a forgotten bump can never ship. Follow-up from PR #16.
There was a problem hiding this comment.
Pull request overview
Adds a make release VERSION=x.y.z workflow that bumps .claude-plugin/plugin.json, commits, and tags, plus a CI guard that fails the release workflow when the pushed tag and plugin.json version disagree. This closes the gap left by PR #16 where the plugin manifest version could drift from release tags.
Changes:
- New
releasetarget inMakefilethat validates the version is semver, refuses to run on a dirty tree, rewritesplugin.json'sversionfield, commits, and creates an annotatedv$(VERSION)tag. - New
verify-versionjob in.github/workflows/release.ymlthat comparesGITHUB_REF_NAME(stripped of leadingv) to theversioninplugin.jsonviajq, blocking GoReleaser vianeeds:on mismatch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Makefile |
Adds release target: semver check, clean-tree check, in-place version rewrite, commit, and annotated tag. |
.github/workflows/release.yml |
Adds verify-version job gating goreleaser to enforce tag/manifest agreement on every release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a make release VERSION=x.y.z target that validates the version, rewrites the version field in .claude-plugin/plugin.json, commits, and tags v$(VERSION). It refuses to run on a dirty tree or with a non-semver version.
Add a verify-version job to the release workflow that gates GoReleaser: on a tag push it compares the tag against plugin.json and fails the release if they differ, so a forgotten bump can never ship.
Follow-up from PR #16.