Skip to content

Comments

V0.1.4#41

Merged
seichhorn merged 5 commits intomasterfrom
v0.1.4
Jan 22, 2020
Merged

V0.1.4#41
seichhorn merged 5 commits intomasterfrom
v0.1.4

Conversation

@emanuega
Copy link
Owner

No description provided.

emanuega and others added 5 commits December 6, 2019 23:24
* updated _run_analysis so GenerateAdaptiveThreshold (GAT) does not crash if the task is reran after a crash. The problem occurs only if the GAT folder is not deleted prior to a rerun. In that case, merlin would see that the .npy files exist so blankCounts would not be initialized. Merlin would crash when blankCounts += is called, because is trying to sum None and a matrix
@emanuega emanuega requested a review from seichhorn January 22, 2020 21:32
@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #41 into master will increase coverage by 0.18%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   86.76%   86.94%   +0.18%     
==========================================
  Files          54       55       +1     
  Lines        4789     4856      +67     
==========================================
+ Hits         4155     4222      +67     
  Misses        634      634
Impacted Files Coverage Δ
test/test_snakemake.py 100% <ø> (ø) ⬆️
test/conftest.py 98.41% <ø> (ø) ⬆️
merlin/analysis/partition.py 86.2% <100%> (+0.24%) ⬆️
merlin/analysis/filterbarcodes.py 94.21% <100%> (ø) ⬆️
merlin/util/spatialfeature.py 90.56% <100%> (+0.02%) ⬆️
merlin/analysis/globalalign.py 66.31% <100%> (+2.67%) ⬆️
merlin/core/dataset.py 90.72% <100%> (+0.02%) ⬆️
merlin/analysis/paralleltaskcomplete.py 84.61% <84.61%> (ø)
merlin/core/analysistask.py 88.7% <91.66%> (+0.39%) ⬆️
merlin/analysis/segment.py 90.13% <94.87%> (+3.08%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 907f4c2...63aebc5. Read the comment docs.

Copy link
Collaborator

@seichhorn seichhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@seichhorn seichhorn merged commit a9409a7 into master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants