Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how feedback and evaluation results are accessed within the repeat-until loops in both
GoatWriterConfig.javaandReviseStoryUntilSatisfied.java. The main improvement is switching from retrieving feedback and evaluation results viacontext.getInput()to using more direct methods on the context object, which simplifies the code and makes it clearer.Refactoring feedback and evaluation retrieval:
goatWriter()andrewriteUntilSatisfied()methods to usecontext.lastAttempt()instead ofcontext.getInput().lastFeedback(), improving clarity and directness. [1] [2]context.getResultToEvaluate()rather thancontext.getInput().resultToEvaluate(), streamlining how the result to be evaluated is obtained. [1] [2]Code cleanup:
GoatWriterConfig.javafor tidier code.