Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to the Embabel Agent framework, focusing on improving annotation-driven configuration, simplifying profile management, and enriching documentation. The changes include the addition of a foundational
@AgentPlatformmeta-annotation, updates to specialized annotations like@EnableAgentShelland@EnableAgentMcpServer, and comprehensive documentation updates in theREADME.mdfile. These updates aim to streamline the configuration process, enhance flexibility, and provide clearer guidance for developers.Enhancements to Annotation-Driven Configuration
Introduction of
@AgentPlatformMeta-Annotation: Added a new@AgentPlatformannotation to act as the core building block for all agent-specific annotations. It simplifies profile activation, auto-configuration imports, and component scanning. This meta-annotation is now used by specialized annotations like@EnableAgentShell,@EnableAgentMcpServer, and@EnableAgentBedrockto activate appropriate Spring profiles.Refactoring of Specialized Annotations:
@EnableAgentShell: Updated to use@AgentPlatform("shell")for activating the "shell" profile, along with detailed documentation on its features and usage.@EnableAgentMcpServer: Refactored to use@AgentPlatform("mcp-server"), removing redundant attributes and enhancing documentation for MCP server configuration.@EnableAgentBedrock: Updated to use@AgentPlatform("shell, bedrock"), with extended documentation on AWS Bedrock integration and configuration properties.@EnableAgents: Enhanced to support additional attributes (loggingTheme,localModels,mcpClients) for fine-grained profile activation.Documentation Improvements
README.md: Updated the documentation to provide detailed explanations of the annotation-driven configuration process, including examples for basic and advanced usage. Added sections on profile activation order, available logging themes, and implementation details of theEmbabelEnvironmentPostProcessor.Key Benefits
@EnableAgentShelland@EnableAgentBedrockwithout worrying about low-level configuration details.@EnableAgentsannotation allows for fine-grained control over logging themes, local models, and MCP clients.