chore(@embark/site): Add —template deprecation notice.
#2079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepCode Report (#74f218)DeepCode analyzed this pull request. |
jrainville
reviewed
Nov 25, 2019
packages/embark/src/cmd/cmd.js
Outdated
| .command('demo') | ||
| .option('--locale [locale]', __('language to use (default: en)')) | ||
| .option('--template <name/url>', __('download a demo template using a known name or a git host URL')) | ||
| .option('--template <name/url>', __('DEPREDCATED download a demo template using a known name or a git host URL')) |
Collaborator
There was a problem hiding this comment.
Suggested change
| .option('--template <name/url>', __('DEPREDCATED download a demo template using a known name or a git host URL')) | |
| .option('--template <name/url>', __('DEPRECATED download a demo template using a known name or a git host URL')) |
michaelsbradleyjr
approved these changes
Nov 25, 2019
Contributor
There was a problem hiding this comment.
Other than the typo @jrainville found, looks good, great work!
In the cli --help text, maybe "depcrecated" could be wrapped in square brackets, e.g. [DEPRECATED].
emizzle
force-pushed
the
chore/template-deprecation-notice
branch
from
5a974e5 to
74f2182
Compare
jrainville
approved these changes
Dec 4, 2019
delete-merged-branch
bot
deleted the
chore/template-deprecation-notice
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--templatedeprecation notices to the site and documentation.More deprecation notices in other repos: