Skip to content

Conversation

@toadkicker
Copy link
Contributor

No description provided.

@toadkicker
Copy link
Contributor Author

toadkicker commented Jul 7, 2017

@iurimatias I don't know about this line;

this.solcVersion = options.contractsConfig.versions.solc;

We usually want to avoid deeply nested config objects. This in a constructor so let the calling member do the hard work here.

I suggest we just make a new immutable class that holds version info for us, and that class would have getters/setters that look them up for us.

@iurimatias
Copy link
Collaborator

iurimatias commented Jul 7, 2017

that line is temporary and will be refactored. I didn't want to do have so many changes (+1163/-715) separate from the main branch for so long. I did f'up with the lint/tests though.

@iurimatias iurimatias merged commit 32a2b7c into embarklabs:develop Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants