Skip to content

Bug fix/build before upload fixed #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 16, 2018
Merged

Bug fix/build before upload fixed #364

merged 5 commits into from
Apr 16, 2018

Conversation

@emizzle
Copy link
Collaborator

@emizzle emizzle commented Apr 15, 2018

  • embark upload now builds and deploys contracts before uploading to the specified platform.
  • embark upload now has an option for --logFile so that it can be passed in to build.
  • Swarm.deploy and IPFS.deploy functions now return a Promise for better bubbling of errors and messages (@iurimatias - will this cause any conflicts with plugin dev? Possibly might require the embark.registerUploadCommand to pass in a callback that returns a Promise?)
  • Fixes issues with the test_app test.js not working properly.
  • Removed duplicated code to build and deploy contracts and replaced with a call to the build function.
  • Updated upload functions to use async exec and removed returns from the callbacks.

emizzle added 5 commits April 15, 2018 20:30
@emizzle
#156326148 Build contracts and dapp before upload.
6b7af4b
@emizzle
#156326148 Updates to build and upload process and fixes for test_app…
31a2a27 
…/test.html

 
* Updated build to include deployment of contracts 
* updated the plugin uploadCmd to be a Promise for better bubbling of errors and messaging.
* updated test.js imports so functionality works correctly.
@emizzle
Passed in success messaging to async callback.
c1c61de
@emizzle
* Removed duplicated code to build and deploy contracts and replaced …
8fc978e 
…with a call to the build function.

* Updated upload functions to use async `exec` and removed returns from the callbacks.
@emizzle
Handling for error during build.
8bdf79b
@iurimatias iurimatias merged commit 39c7e3c into develop Apr 16, 2018
@emizzle emizzle deleted the bug_fix/build-before-upload-fixed branch April 17, 2018 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iurimatias iurimatias iurimatias approved these changes

@jrainville jrainville Awaiting requested review from jrainville

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emizzle @iurimatias