Support setting log level as an argument #370
Merged
+62
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intercepting logs for embark run and including logLevel for displayed logs.
* Add loglevel and logfile switch to `embark build` * Support existing `loglevel` and `logfile` switch for `embark run/upload` * make casing consistent for `loglevel` and `logfile` * remove passing engine to `build()` and instead pass needed objects in options. * prevent duplicate plugin initiation (above point) * allow `Events` object to be passed to `Engine` constructor and `init()` * prevent echo of upload commands to allow interception and control via logging
jrainville
approved these changes
Apr 19, 2018
iurimatias
approved these changes
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
embark buildloglevelandlogfileswitch forembark run/uploadloglevelandlogfilebuild()and instead pass needed objects in options.Eventsobject to be passed toEngineconstructor andinit()