Draft
Conversation
rappet
force-pushed
the
stm32-standby
branch
from
c54d011 to
f1a423f
Compare
Dirbaio
reviewed
Feb 17, 2025
embassy-stm32/src/pwr.rs
Outdated
| /// it will not be disabled and can still reset the core if it was not pet. | ||
| /// This can also be used to wake up after and inaccurate amount of time has passed in standby mode, | ||
| /// which has the advantage that it is in most cases less power hungry than the RTC. | ||
| pub fn standby(_config: &StandbyConfig) { |
Member
There was a problem hiding this comment.
Suggested change
| pub fn standby(_config: &StandbyConfig) { | |
| pub fn standby(_config: &StandbyConfig) -> ! { |
denotes nicely that this doesn't return.
Author
There was a problem hiding this comment.
Done, had to move unreachable! out of the critical section.
rappet
force-pushed
the
stm32-standby
branch
from
f1a423f to
ad49b8b
Compare
Currently tested only with a STM32F103 and STM32L031 - STM32F103 current was <50uA for a whole "BluePill" devboard from WeAct Studio, with the Power LED desoldered. - WKUP behaves weird, need to debug - STM32L031 was tested using a custom PCB with <3uA - STM32F411CEU was tested on a "BlackPill" devboard from WeAct Studio. - STM32H743VIT6 was tested on a devboard from WeAct Studio. For the measurements I used a very cheap multimeter. I only expect the measurements to be roughly in the same order of magnitude. If not specified, current was not measured. WKUP has to be reworked to be a stable API Signed-off-by: Raphael Peters <rappet@rappet.de>
rappet
force-pushed
the
stm32-standby
branch
from
ad49b8b to
d2c24d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently work in progress. Following things are missing in my opinion.
Tested only with an STM32F103 and STM32L031
I don't have a good idea how to build a good API for the WKUP pins.
They are quite a bit different than usual hardware as you can just steal the affected pins from other peripherals
as the chip is stopped anyway (and you might have already used them for a button that you also want to use for waking for example).
I currently see an array/struct with a Config for each pin.
Depending on series, there is also some difference between the WKUP pins. I know at least of those variants: