Skip to content

Comments

fix(stm32): handle half-duplex in ringbuffered read#3952

Closed
badrbouslikhin wants to merge 1 commit intoembassy-rs:mainfrom
thermigo:main
Closed

fix(stm32): handle half-duplex in ringbuffered read#3952
badrbouslikhin wants to merge 1 commit intoembassy-rs:mainfrom
thermigo:main

Conversation

@badrbouslikhin
Copy link
Contributor

This PR fixes an issue introduced in PR #3379, where the transmitter disable/receiver enable operation in half-duplex mode was moved from the flush method to the read methods. However, that PR did not account for the ringbuffered read method.

@lulf lulf added this pull request to the merge queue Mar 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2025
@Dirbaio Dirbaio added this pull request to the merge queue Mar 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2025
@Dirbaio Dirbaio added this pull request to the merge queue Mar 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2025
@Dirbaio
Copy link
Member

Dirbaio commented Mar 11, 2025

@badrbouslikhin it seems this is causing the stm32l152re/usart_rx_ringbuffered test to fail

@badrbouslikhin
Copy link
Contributor Author

badrbouslikhin commented Mar 11, 2025

I checked the reference manual (RM0038) and found no obvious reason for the test failure.
Also, the test does not appear to use a half-duplex USART, so the following condition should fail: if r.cr3().read().hdsel() && r.cr1().read().te() and this commit shouldn't be doing much.

I am not sure what's going on here, I'll check if I have a board stm32l1xxx board I can test at the office.

@badrbouslikhin
Copy link
Contributor Author

badrbouslikhin commented Mar 13, 2025

I couldn't find a stm32l1xxx board. I can't debug this further at the moment.

Can you check it's not an issue with the physical setup of that board? I checked recent PRs, HIL tests didn't seem to run.

@Dirbaio
Copy link
Member

Dirbaio commented Apr 6, 2025

okay I think the tes tis just flaky. It already randomly fails, this PR just makes it fail more often. Let's just ignore it.

Had to create a new PR #4054 . The next time please enable the "allow maintainers to push" checkbox when creating the PR.

@Dirbaio Dirbaio closed this Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants