embassy-net-esp-hosted: Add basic softap and scanning support #3972
Open
mjwells2002 wants to merge 6 commits intoembassy-rs:mainfrom
Open
embassy-net-esp-hosted: Add basic softap and scanning support #3972mjwells2002 wants to merge 6 commits intoembassy-rs:mainfrom
mjwells2002 wants to merge 6 commits intoembassy-rs:mainfrom
Conversation
mjwells2002
changed the title
Author
|
Not sure if this is the best way to do this but it has all the features i wanted to add, and it works |
lulf
reviewed
Mar 31, 2025
Member
lulf
left a comment
lulf
left a comment
There was a problem hiding this comment.
General approach looking good, just a question about the ioctl buf.
Author
|
took a while to get back to this but managed to today, i updated the ioctl macro to take in the length of the buffer and set the size increase for only scanning, also changed it to prevent a runtime panic if more scan results are returned then can be handled, im not quite sure the correct way to deal with that situation, so its just ignored for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a draft because of the modifications to proto.rs, unsure if directly modifying this is correct