Fix dll files opencv for win32 (graph) #169
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
=======================================
Coverage 88.07% 88.07%
=======================================
Files 23 23
Lines 1057 1057
Branches 556 556
=======================================
Hits 931 931
Misses 59 59
Partials 67 67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| target_link_libraries(ACC_MNIST BuildGraph) | ||
|
|
||
| if (NOT CMAKE_BUILD_TYPE) | ||
| set(CMAKE_BUILD_TYPE "Debug") |
There was a problem hiding this comment.
I suggest to make "Release" as a default type
There was a problem hiding this comment.
I found an error with copying files.
There was a problem hiding this comment.
before that, opencv was always going to debug. I will add in the instructions instead of the cmake command cmake .. the cmake command -DCMAKE_BUILD_TYPE=Release command, and only then will our idea of copying dll files from the release or debug folder work.
| if ("${CMAKE_BUILD_TYPE}" STREQUAL "DEBUG") | ||
| set(CMAKE_BUILD_TYPE "Debug") | ||
| endif() | ||
| if ("${CMAKE_BUILD_TYPE}" STREQUAL "RELEASE") | ||
| set(CMAKE_BUILD_TYPE "Release") | ||
| endif() |
There was a problem hiding this comment.
You can pass the type as is (no need to convert it to specific case)
Semyon1104
force-pushed
the
AndreySorokin7/Fix_dll_for_win32_graph
branch
from
4c18119 to
5a525b3
Compare
No description provided.