Pythonify and enhance the tests. #14
Merged
screeley merged 3 commits intoembedly:masterfrom Jun 17, 2013
Merged
Conversation
…does. Remove the `original_url` from the test to avoid confusion. Note: working with __getattr__ and __setattr__ this way is problematic. Those attributes exist on the Url class, not AttrDict. So while this is an improvement, it's perpetuating bad behavior.
- break out and add some new tests - use assertEqual() - use setUp() instead of __init__() - remove the ValueError on missing self.key that will never be reached - use assertRaises() for exception testing
screeley
added a commit
that referenced
this pull request
Jun 17, 2013
Pythonify and enhance the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit messages are pretty clear. Basic Pythonifying of the tests along with a few new tests.