Conversation
96e0f9d to
31c4748
Compare
simonihmig
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is implemented in a similar way to what we did for broccoli-concat but I added a few extra older node versions since the travis file didn't define what versions we supported
I can't guarantee that this testing situation won't have some side-effects if we start to update other dependencies but since the main thing we want to release is just inlining code that was already in use I propose that we do the following:
There will likely be a need to remove some old node versions from testing anyway while upgrading deprecated packages so the conservative approach will likely be the right one 👍