Test deprecate-router-events codemod

[rajasegar]

ember-cli/ember-cli-update-codemods-manifest#21

ember-cli/ember-cli-update-codemods-manifest#24

[rajasegar]

@kellyselden Any idea how I can re-trigger the build for this PR?

[kellyselden]

Looks like there's a failure with newlines with the codemod. https://travis-ci.org/ember-cli/ember-cli-update/jobs/593930566#L4994

[rajasegar]

@kellyselden I think it's due to the quote difference single vs double , not because of newline character , I have fixed the same in the codemod, so need to trigger the build again and check. That's why I have asked.
ember-codemods/ember-3x-codemods#8

[kellyselden]

Can you rebase master? I made some improvements to the test times.

[kellyselden]

it's still a newline issue.

      -      "index.js": "import Router from '@ember/routing/router';\r\nimport { inject as service } from '@ember/service';\r\n\r\nexport default Router.extend({\r\n  currentUser: service('current-user'),\r\n\r\n  init() {\r\n    this._super(...arguments);\r\n\r\n    this.on('routeWillChange', transition => {\r\n      if (!this.currentUser.isLoggedIn) {\r\n        transition.abort();\r\n        this.transitionTo('login');\r\n      }\r\n    });\r\n\r\n    this.on('routeDidChange', transition => {\r\n      ga.send('pageView', {\r\n        pageName: privateInfos.name\r\n      });\r\n    });\r\n  }\r\n});\r\n"
      +      "index.js": "import Router from '@ember/routing/router';\r\nimport { inject as service } from '@ember/service';\r\n\r\nexport default Router.extend({\r\n  currentUser: service('current-user'),\r\n\r\n  init() {\r\n    this._super(...arguments);\r\n    this.on('routeWillChange', transition => {\r\n      if (!this.currentUser.isLoggedIn) {\r\n        transition.abort();\r\n        this.transitionTo('login');\r\n      }\r\n    });\r\n\r\n    this.on('routeDidChange', transition => {\r\n      ga.send('pageView', {\r\n        pageName: privateInfos.name\r\n      });\r\n    });\r\n  }\r\n});\r\n"

[rajasegar]

@kellyselden Yes, from the beginning there was the new line issue, but apart from that we also had other issues within the transform. Finally, I figured out all of them. Thanks for reviewing.