Post-merge-review: Fix template-no-invalid-link-text: skip when link contains non-text children#2680
Merged
NullVoxPopuli merged 2 commits intoember-cli:masterfrom Apr 14, 2026
Conversation
…hildren Match upstream ember-template-lint's no-invalid-link-text behavior (lib/rules/no-invalid-link-text.js L53-56): if any child of the link is not a TextNode, the link content is opaque and should not be flagged. Handles real-world patterns like <a><MyComponent /> </a> where the link text comes from a component's template, which the linter cannot analyze. Removes two tests that asserted stricter-than-upstream behavior on <a><span>click here</span></a>. Per upstream, this case can't be reliably analyzed and should not be flagged.
| if (result.hasDynamic) { | ||
| hasDynamic = true; | ||
| } | ||
| // Match upstream: if the link contains any non-TextNode child (component, |
Contributor
There was a problem hiding this comment.
comments explaining what go in the PR description don't mke sense :p
NullVoxPopuli
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match upstream ember-template-lint's no-invalid-link-text behavior (lib/rules/no-invalid-link-text.js L53-56): if any child of the link is not a TextNode, the link content is opaque and should not be flagged. Handles real-world patterns like where the link text comes from a component's template, which the linter cannot analyze.
Removes two tests that asserted stricter-than-upstream behavior on click here. Per upstream, this case can't be reliably analyzed and should not be flagged.