Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component with / in the name should not be converted #61

Open
mixonic opened this issue Jul 12, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@mixonic
Copy link
Collaborator

commented Jul 12, 2017

Components with / in their invocation, ala {{foo/foo-bar}} should not be converted. Alternatively they could simple be automatically renamed to foo-foo-bar, but this could have other unintended side-effect wrt the {{component helper.

My suggestion is that we throw if any component with / in the name is detected and request the user refactor that code before running the migrator again.

Refs: #60

@billybonks

This comment has been minimized.

Copy link

commented Jul 12, 2017

hmm, that may be a good idea, to do the refactor before hand. ill be hard to catch dynamic invocations though.

@billybonks

This comment has been minimized.

Copy link

commented Jul 12, 2017

what do you think about a dry run, where we can build a list of components that need to be migrated before the run can occur?

or, we could do a partial migration, that migrates everything the migrator can, then leaves / components in the app directory, since we have the fallback resolver

@mixonic mixonic changed the title Component with - in the name should not be converted Component with / in the name should not be converted Jul 14, 2017

@rwjblue

This comment has been minimized.

Copy link
Member

commented Jul 14, 2017

Not sure I agree with the lead in here.

Many / invoked components are properly localized (and this was the primary motivation for "invoked renderables" concept here). I suppose we could "opt out" of this all intelligent localization of components when we hit a dynamic {{component usage, but that feels pretty bad TBH.

IMHO, the migrator should emit output after running that lists dynamic callsites so that they can be audited...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.