Add prepend information to fastboot-dist/package.json#103
Closed
danmcclain wants to merge 1 commit intoember-fastboot:masterfrom
danmcclain:asset-prepend-info
Closed
Add prepend information to fastboot-dist/package.json#103danmcclain wants to merge 1 commit intoember-fastboot:masterfrom danmcclain:asset-prepend-info
fastboot-dist/package.json#103danmcclain wants to merge 1 commit intoember-fastboot:masterfrom
danmcclain:asset-prepend-info
Conversation
This was referenced Jan 28, 2016
Member
Author
|
@tomdale thoughts? I've verified that the combination of these 2 PRs allows for prod build |
Contributor
|
After discussing this with @danmcclain, I had concerns about requiring manifest consumers to apply a set of arbitrary operations on the manifest to get the correct list of files—at minimum, it seems like the operations should be applied on the generation side, not the consumption side. Consuming the manifest should be very straightforward and not require additional code. I am going to take a stab at updating the Ember CLI addon to take into account the broccoli-asset-rev rewriting, by not generating the manifest until it has applied its renaming trees. |
xg-wang
pushed a commit
to xg-wang/ember-cli-fastboot
that referenced
this pull request
Nov 16, 2020
…esponse Add README section on scraping issues and chunkedResponse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grabs the prepend option set when fingerprinting the files and appends it to the package.json file so that
ember-fastboot-servercan remove the prepend details. Used by the changes added hereThis PR plus ember-fastboot/fastboot#11 closes #102
For asset-rev to manage the
fastboot-dist/package.json,'json'must be added to thereplaceExtensionssetting in brocolli-asset-rev