Skip to content

Add prepend information to fastboot-dist/package.json#103

Closed
danmcclain wants to merge 1 commit intoember-fastboot:masterfrom
danmcclain:asset-prepend-info
Closed

Add prepend information to fastboot-dist/package.json#103
danmcclain wants to merge 1 commit intoember-fastboot:masterfrom
danmcclain:asset-prepend-info

Conversation

@danmcclain
Copy link
Copy Markdown
Member

Grabs the prepend option set when fingerprinting the files and appends it to the package.json file so that ember-fastboot-server can remove the prepend details. Used by the changes added here

This PR plus ember-fastboot/fastboot#11 closes #102

For asset-rev to manage the fastboot-dist/package.json, 'json' must be added to the replaceExtensions setting in brocolli-asset-rev

@danmcclain
Copy link
Copy Markdown
Member Author

@tomdale thoughts? I've verified that the combination of these 2 PRs allows for prod build

@tomdale
Copy link
Copy Markdown
Contributor

tomdale commented Feb 1, 2016

After discussing this with @danmcclain, I had concerns about requiring manifest consumers to apply a set of arbitrary operations on the manifest to get the correct list of files—at minimum, it seems like the operations should be applied on the generation side, not the consumption side. Consuming the manifest should be very straightforward and not require additional code.

I am going to take a stab at updating the Ember CLI addon to take into account the broccoli-asset-rev rewriting, by not generating the manifest until it has applied its renaming trees.

@tomdale tomdale closed this Feb 1, 2016
xg-wang pushed a commit to xg-wang/ember-cli-fastboot that referenced this pull request Nov 16, 2020
…esponse

Add README section on scraping issues and chunkedResponse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong manifest file paths

2 participants