process.env.FASTBOOT_DISABLED to disable fastboot build#338
Merged
tomdale merged 1 commit intoember-fastboot:masterfrom Feb 6, 2017
Merged
process.env.FASTBOOT_DISABLED to disable fastboot build#338tomdale merged 1 commit intoember-fastboot:masterfrom
tomdale merged 1 commit intoember-fastboot:masterfrom
Conversation
Contributor
|
We took a similar approach to avoid the double build times, and only enable fastboot for deployment builds. Would be nice to see this land 👍 |
Contributor
|
I don't love this, but it's definitely solving a real need. Let's keep it around until the double build problem is addressed. @kellyselden, can you make sure we note this flag in the README so it's not just a secret handshake you have to learn about? |
kellyselden
force-pushed
the
manual-disable
branch
from
12ee892 to
5121d3a
Compare
Member
Author
|
Added to README. @tomdale need your approval on my wordsmithing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would be a pre 1.0 power user flag to disable the fastboot build while retaining the fastboot service. Use case is large legacy apps that already take forever to build. Developing locally would like the option to disable fastboot while CI does the fastboot builds. I tried blacklisting the addon, but then I got
Error: Attempting to inject an unknown injection: 'service:fastboot'on CI because the fastboot service was gone.I brought this up in slack and there was at least one other user with a fork of fastboot doing this check as well as me.