using internal flag _booted instead of instanceBooted#147
Merged
kratiahuja merged 1 commit intoember-fastboot:masterfrom Jun 19, 2017
Merged
using internal flag _booted instead of instanceBooted#147kratiahuja merged 1 commit intoember-fastboot:masterfrom
_booted instead of instanceBooted#147kratiahuja merged 1 commit intoember-fastboot:masterfrom
Conversation
kratiahuja
reviewed
Jun 4, 2017
|
|
||
| return instance.boot(bootOptions); | ||
| }) | ||
| .then(() => result.instanceBooted = true) |
Contributor
Author
|
Why to have it ? If app instance already has _booted prop which does same thing, is there reason not using it?
… On 4 Jun 2017, at 22:23, Krati Ahuja ***@***.***> wrote:
@kratiahuja commented on this pull request.
In src/ember-app.js:
> @@ -233,7 +233,6 @@ class EmberApp {
return instance.boot(bootOptions);
})
- .then(() => result.instanceBooted = true)
Why remove this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
bekzod
force-pushed
the
remove-booted-flag
branch
from
3149097 to
5ba4258
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.