Skip to content

handle headers as both strings and arrays #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kellyselden wants to merge 2 commits into from
Closed

handle headers as both strings and arrays #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eed96af
handle headers as both strings and arrays
Sep 22, 2016
508e231
add array header test
Sep 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/fastboot-headers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,14 @@ function FastBootHeaders(headers) {
this.headers = {};

for (var header in headers) {
this.headers[header] = headers[header].split(', ');
let value = headers[header];

// convert to array if not already
if (typeof value === 'string') {
value = value.split(', ');
}

this.headers[header] = value;
}
}

Expand Down
10 changes: 9 additions & 1 deletion test/fastboot-headers-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,15 @@ describe('FastBootHeaders', function() {
expect(headers.has('host')).to.be.false;
});

it('handles header values that are already an array', function() {
var headers = {
'x-test-header': ['value1', 'value2']
};
headers = new FastBootHeaders(headers);

expect(headers.getAll('x-test-header')).to.deep.equal(['value1', 'value2']);
});

it('appends entries onto a header, regardless of casing', function() {
var headers = new FastBootHeaders();

Expand Down Expand Up @@ -149,4 +158,3 @@ describe('FastBootHeaders', function() {
expect(entriesIterator.next()).to.deep.equal({ value: undefined, done: true });
});
});