Skip to content

Conversation

@Dhaulagiri
Copy link
Contributor

@Dhaulagiri Dhaulagiri commented Mar 17, 2018

  • Ensures that we can correctly create a nested directory in the event that a package's name is @myscope/package-name. This was breaking because the @myscope directory wasn't being created before.
  • Ensures that we don't rely on matching names to be at the start of a package's name to allow for a scope to be at the beginning

Fixes #46, but I'm honestly not 100% sure if this is the best approach.
Fixes #111

@pzuraq
Copy link
Contributor

pzuraq commented Mar 18, 2018

Based on what’s going on in #111 I think I’d like to reduce the logo constraint even further. It should probably default to ember if nothing else is matched, and should have a manual override

@bravo-kernel
Copy link
Contributor

Defaulting to the Ember logo would be awesome, much appreciated

* Ensures that we can correctly create a nested directory
* Ensures that we don't rely on matching names to be at the start of a
package's name to allow for a scope
@Dhaulagiri
Copy link
Contributor Author

@pzuraq I updated my change to default to ember if there is no match on ember-cli or ember-data. Some local testing indicates that this now fixes #111 as well.

@pzuraq pzuraq merged commit d2e8c73 into ember-learn:master Mar 19, 2018
@pzuraq
Copy link
Contributor

pzuraq commented Mar 19, 2018

Awesome, thanks for taking this on!

@Dhaulagiri Dhaulagiri deleted the br-scoped branch May 5, 2018 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants