Skip to content

Conversation

@san650
Copy link
Contributor

@san650 san650 commented Apr 10, 2018

This fixes a known issue in ember-router-scroll where you can get randomly failing tests.

See DockYard/ember-router-scroll#72

@san650 san650 force-pushed the update-ember-router-scroll branch from b95d443 to d1eee14 Compare April 10, 2018 22:50
@san650
Copy link
Contributor Author

san650 commented Apr 12, 2018

For some reason, beta and canary are failing with this change. This is the error in travis-ci

https://travis-ci.org/ember-learn/ember-cli-addon-docs/builds/364861345

not ok 1 Chrome 65.0 - Global error: Uncaught TypeError: Cannot read property 'String' of undefined at http://localhost:7357/assets/vendor.js, line 123762
    ---
        Log: |
            { type: 'warn',
              text: '\'WARNING: Library "Ember" is already registered with Ember.\'\n' }
            { type: 'error',
              text: 'Uncaught TypeError: Cannot read property \'String\' of undefined at http://localhost:7357/assets/vendor.js, line 123762\n' }
    ...
not ok 2 Chrome 65.0 - Global error: Uncaught Error: Assertion Failed: The tests file was not loaded. Make sure your tests index.html includes "assets/tests.js". at http://localhost:7357/assets/vendor.js, line 25530
    ---
        Log: |
            { type: 'error',
              text: 'Uncaught Error: Assertion Failed: The tests file was not loaded. Make sure your tests index.html includes "assets/tests.js". at http://localhost:7357/assets/vendor.js, line 25530\n' }
    ...

Any idea what the issue might be?

@pzuraq
Copy link
Contributor

pzuraq commented Apr 13, 2018

This is an issue upstream with Ember, it should be fixed soon, the fix has already been merged I believe so we just have to wait for canary to update.

This fixes a known issue where you can get randomly failing tests.

See DockYard/ember-router-scroll#72
@san650 san650 force-pushed the update-ember-router-scroll branch from d1eee14 to 44e9551 Compare April 19, 2018 11:15
@san650
Copy link
Contributor Author

san650 commented Apr 19, 2018

Thanks @pzuraq for checking this!

@san650
Copy link
Contributor Author

san650 commented Apr 19, 2018

Tests green now 😃

@pzuraq pzuraq merged commit 123ff37 into ember-learn:master Apr 19, 2018
@san650 san650 deleted the update-ember-router-scroll branch April 19, 2018 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants