-
-
Notifications
You must be signed in to change notification settings - Fork 143
[cleanup] Simplifies the API doc navigation #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Nice – I agree we should fix this up! Initial thoughts are nav is getting a little cluttered. Thinking about ways we can clean it up...
|
| {{#if (is-array items)}} | ||
| {{#if (is-array items)}} | ||
| {{#each items as |item|}} | ||
| {{docs-viewer/x-item item.name (concat root '.api.item') item.path}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be x-nav-item
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah, definitely
|
Generally agree with everything you’re saying design-wise, feel free to change it! I can get to it on Monday most likely. As for pulling API docs out, I think that’d be a good idea actually! Basically give them their own tab. It may be a little tricky with the Sandbox, but we can make it work! |
|
So coming back to this, I actually really agree, it does feel like the nav has gotten pretty cluttered and is trying to do too much: Comparing it to the Ember API docs: They just link to the individual modules. For really simple addons/libraries, it may make sense to have the individual addon members listed in the nav, but in Also, regarding the other question you had:
I think this depends on the addon. For |
* Simplifies the API doc navigation. It now only shows the modules themselves, and none of their items (that is left to the API docs page). * Brings back nested subnavigation menus * Adds the `break-on` helper which allows us to specify when a string should break by inserting zero-width spaces
70da25c to
0d48efb
Compare
|
Just ran it locally and it looks great! 👍 from me |


Simplifies the API doc navigation. It now only shows the modules
themselves, and none of their items (that is left to the API docs page).
Brings back nested subnavigation menus
Adds the
break-onhelper which allows us to specify when a stringshould break by inserting zero-width spaces
Random cleanup
Upgrades Tailwind
The one disadvantage to going this route is it hurts power users who are familiar with the library already and just want to be able to lookup an import really quickly. I think this could be better solved by having a dedicated reference page. I didn't add it in this PR, but plan on trying to figure it out soon: