Skip to content

Conversation

@alexlafroscia
Copy link
Contributor

Closes #78

@alexlafroscia alexlafroscia force-pushed the quickstart-guide-improvements branch from ca5861f to 7814bd6 Compare March 12, 2018 18:03
@gossi
Copy link
Contributor

gossi commented Mar 13, 2018

While you are at it. In point 4 of the quickstart "Create your docs skeleton". It says the file: tests/dummy/app/pods/docs/template.hbs from my understanding should be tests/dummy/app/templates/docs/template.hbs (pods vs templates) - can you confirm my assumption and fix this accordingly?

@alexlafroscia
Copy link
Contributor Author

I think that template is correct... If you have a docs pod, then the file name they reference is right.

@pzuraq
Copy link
Contributor

pzuraq commented Mar 13, 2018

We have decided to switch all examples and recommendations to not use pods in the docs, because the recommended format by Ember is classic structure. I don't think you need to update that as well (though it would be appreciated) but it seems like a new eslint rule has been added that is causing tests to fail, we need to call this._super(...arguments) in an init function somewhere

@pzuraq pzuraq merged commit a39dd1a into ember-learn:master Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants