Bump ember-cli to ~6.12.0 in test apps#1202
Merged
NullVoxPopuli merged 1 commit intoemberjs:mainfrom Apr 24, 2026
Merged
Conversation
ember-cli 5.12.0's EmberApp._initVendorFiles unconditionally reads
emberSource.paths.debug/prod/testing. ember-source on main no longer
ships `paths`, so the test build crashes with:
TypeError: Cannot read properties of undefined (reading 'debug')
at EmberApp._initVendorFiles (.../ember-app.js:360:44)
ember-cli 6.x guards that branch with `emberSource.paths ? {...} : {}`,
which fixes the crash and is what's needed to keep ember-qunit green
in ember-source @ main ecosystem-ci runs.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ember-clifrom~5.12.0to~6.12.0intest-appandtest-buildtime-options-app.pnpm-lock.yamlaccordingly.Why
The
ember-source @ mainecosystem-ci job forember-qunitis failing in the classic-build pipeline:ember-cli5.12.0's_initVendorFilesreadsemberSource.paths.debug/.prod/.testingunconditionally.ember-sourceonmainno longer ships apathsobject (classic-build vendor-concat is obsolete there), so the build crashes before a single test runs.ember-cli6.x guards the branch withemberSource.paths ? {...} : {}, which handles the missingpathscleanly.Test plan
pnpm installsucceeds with the updated specifiertest-appember build --environment=testcompletes successfully locallyember-source @ mainecosystem-ci job passes against this branch