[DOC release] Update reduce_computed_macros.js #14904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should |
locks
changed the title
|
Hi @bwbuchanan
I think you had a point here. The current YUIDoc doesn't really reflect the example; the examples are clear, but the YUIDoc is confusing. 😄 Will you do a PR? |
8 tasks
weswigham
pushed a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Oct 9, 2017
This PR adds some of the missing definitions from here: https://www.emberjs.com/api/ember/2.15/namespaces/Ember.computed/methods/union?anchor=union Note: the documentation there suggests that propertyKey is a single parameter, which is incorrect/unclear per the discussion in emberjs/ember.js#14904. Hence, I added them as ... arguments instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14891 (comment).