[CLEANUP] Remove DEPRECATE_COMPONENT_TEMPLATE_RESOLVING #20881

tcjr · 2025-03-22T15:50:59Z

Related to #20816.

The removal of this deprecation means that the resolver's internal function layoutFor would always return null. It's only called in one place, so I removed the function and updated lookupComponentPair to use null in place of the return from layoutFor.

kategengler · 2025-03-24T21:21:45Z

packages/@ember/-internals/glimmer/tests/integration/components/append-test.js

    );
  }

-  [`${testUnless(


@NullVoxPopuli can you confirm that these tests were not erroneously marked with the deprecation? At a glance it seems like they were coincidentally using the deprecated behavior but I'm not sure.

These are testing lifecycle hooks -- so perhaps they could be adapted to a non-deprecated template.

We'd probably want to keep these tests around until we get rid of @ember/component (or move it out to a library somewhere)

Do you know how to adapt them to not use the deprecated feature? If you put an example here @tcjr may be able to resurrect those tests.

* Port the sizes workflow from glimmer-vm * Explicity set permission * Adjust permissions * Use pull_request_target for safety * pull_requset_target => pull_request * Try to not be vulnerable to basic attacks in GH Actions * Don't upload the whole dist as an artifact * Cache main on main * Build on #main * Rename * Updates * Concat the run id * Fix path * Fix paths * paths

Fix size PR workflow

Fix size comment workflow

* AHHHHH * Test empty commit * Test empty commit * Test empty commit * Trigger Main CI * Test empty commit * Allow workflow_dispatch * Test empty commit * fix * Test empty commit * Fix run-id * what * what * AHHHH * AHHHH * AHHHH * AHHHH * AHHHH * AHHHH * AHHHH * AHHHH * AHHHH * Fix PR number saving * AHHHH * AHHHH * AHHHH * AHHHH * AHHHH * AHHHH * ope * All * Shrink output * Fix paths

* Diff dev assets * Add diff to size action * Fix diff * Fix diff * Update size * Demo * hm * hm * hm * hm * hm * hm * hm * hm * Revert "Demo" This reverts commit c520b6f.

NullVoxPopuli · 2025-03-27T20:29:32Z

packages/@ember/-internals/glimmer/tests/integration/components/append-test.js

-        layoutName: 'components/x-parent',
-      }),
-
-      resolveableTemplate:


if we change this to template, and then unwrap the expectDeprecation thing, we should be good to go!

(keeping the tests, but also resolving the deprecation)

I restored the tests (unchanged) in this file, removing the testUnless deprecation wrapper.

I'm not sure how to fix the failing tests; I'm still working on that. Just changing resolveableTemplate to template was insufficient (different resolution errors).

* Removed tests targeting DEPRECATE_TEMPLATE_ACTION * Remove code deprecated via DEPRECATE_TEMPLATE_ACTION * Restored non-modifier bits of the action modifier source file * Update packages/@ember/-internals/glimmer/lib/resolver.ts * Update packages/@ember/-internals/glimmer/lib/resolver.ts * Update packages/@ember/-internals/glimmer/lib/resolver.ts * Update packages/@ember/-internals/glimmer/lib/resolver.ts * Removed node test with action modifier --------- Co-authored-by: Katie Gengler <katie@kmg.io>

github-actions · 2025-03-31T19:30:54Z

Development Assets

Diff

--- main/out.txt	2025-03-28 16:02:56.000000000 +0000
+++ pr/./pr-14199927699/out.txt	2025-04-01 15:39:40.000000000 +0000
@@ -1,6 +1,6 @@
  2.2M └─┬ .
 1015K   ├─┬ @ember
- 206K   │ ├─┬ -internals
+ 205K   │ ├─┬ -internals
   69K   │ │ ├─┬ views
   64K   │ │ │ └─┬ lib
   23K   │ │ │   ├── mixins
@@ -14,7 +14,7 @@
   26K   │ │ ├─┬ meta
   21K   │ │ │ └── lib
   11K   │ │ ├── owner
- 9.6K   │ │ ├── deprecations
+ 9.4K   │ │ ├── deprecations
  7.4K   │ │ ├── metal
  7.0K   │ │ ├── string
  5.1K   │ │ ├── glimmer

Details

This PR main

Dev

 2.2M └─┬ .
1015K   ├─┬ @ember
 205K   │ ├─┬ -internals
  69K   │ │ ├─┬ views
  64K   │ │ │ └─┬ lib
  23K   │ │ │   ├── mixins
  22K   │ │ │   ├── system
  10K   │ │ │   ├── views
 4.3K   │ │ │   └── compat
  35K   │ │ ├─┬ runtime
  30K   │ │ │ └─┬ lib
  21K   │ │ │   ├── mixins
 5.7K   │ │ │   └── ext
  26K   │ │ ├─┬ meta
  21K   │ │ │ └── lib
  11K   │ │ ├── owner
 9.4K   │ │ ├── deprecations
 7.4K   │ │ ├── metal
 7.0K   │ │ ├── string
 5.1K   │ │ ├── glimmer
 4.9K   │ │ ├── utils
 4.9K   │ │ ├── routing
 4.5K   │ │ ├── error-handling
 4.5K   │ │ ├── utility-types
 4.2K   │ │ ├── container
 4.2K   │ │ ├── browser-environment
 4.1K   │ │ └── environment
 183K   │ ├─┬ routing
  28K   │ │ └── lib
 149K   │ ├─┬ object
  66K   │ │ └─┬ lib
  62K   │ │   └── computed
 114K   │ ├─┬ template-compiler
 109K   │ │ └─┬ lib
  20K   │ │   ├── plugins
 4.6K   │ │   ├── system
 4.1K   │ │   └── -internal
  66K   │ ├─┬ application
 5.6K   │ │ └── lib
  52K   │ ├─┬ debug
  21K   │ │ └── lib
  38K   │ ├─┬ array
 4.9K   │ │ └── lib
  31K   │ ├─┬ engine
 4.7K   │ │ └── lib
  27K   │ ├── runloop
  22K   │ ├─┬ utils
  18K   │ │ └── lib
  20K   │ ├── helper
  11K   │ ├── destroyable
 9.8K   │ ├── instrumentation
 9.4K   │ ├── controller
 7.4K   │ ├── service
 7.2K   │ ├── owner
 6.2K   │ ├── component
 5.6K   │ ├── canary-features
 5.5K   │ ├── modifier
 5.1K   │ ├── template-compilation
 5.0K   │ ├── enumerable
 5.0K   │ ├── test
 4.4K   │ ├── template
 4.4K   │ ├── renderer
 4.2K   │ ├── deprecated-features
 4.1K   │ ├── template-factory
 4.1K   │ └── version
 709K   ├── shared-chunks
 384K   ├─┬ @glimmer
 166K   │ ├── runtime
  60K   │ ├── opcode-compiler
  30K   │ ├── manager
  22K   │ ├── validator
  14K   │ ├── program
  12K   │ ├── reference
  11K   │ ├── destroyable
  10K   │ ├─┬ tracking
 4.4K   │ │ └── primitives
  10K   │ ├── util
 8.1K   │ ├── node
 7.3K   │ ├── global-context
 6.4K   │ ├── wire-format
 5.0K   │ ├── vm
 4.9K   │ ├── encoder
 4.6K   │ ├── owner
 4.1K   │ └── env
  60K   ├─┬ ember-testing
  56K   │ └─┬ lib
  14K   │   ├── test
  14K   │   ├── helpers
  10K   │   ├── ext
 6.5K   │   └── adapters
  31K   ├── backburner.js
  25K   ├── ember
  24K   ├── route-recognizer
  18K   ├─┬ @simple-dom
  14K   │ └── document
 9.2K   ├── dag-map
 4.3K   ├── rsvp
 4.3K   └── router_js

 2.2M └─┬ .
1015K   ├─┬ @ember
 206K   │ ├─┬ -internals
  69K   │ │ ├─┬ views
  64K   │ │ │ └─┬ lib
  23K   │ │ │   ├── mixins
  22K   │ │ │   ├── system
  10K   │ │ │   ├── views
 4.3K   │ │ │   └── compat
  35K   │ │ ├─┬ runtime
  30K   │ │ │ └─┬ lib
  21K   │ │ │   ├── mixins
 5.7K   │ │ │   └── ext
  26K   │ │ ├─┬ meta
  21K   │ │ │ └── lib
  11K   │ │ ├── owner
 9.6K   │ │ ├── deprecations
 7.4K   │ │ ├── metal
 7.0K   │ │ ├── string
 5.1K   │ │ ├── glimmer
 4.9K   │ │ ├── utils
 4.9K   │ │ ├── routing
 4.5K   │ │ ├── error-handling
 4.5K   │ │ ├── utility-types
 4.2K   │ │ ├── container
 4.2K   │ │ ├── browser-environment
 4.1K   │ │ └── environment
 183K   │ ├─┬ routing
  28K   │ │ └── lib
 149K   │ ├─┬ object
  66K   │ │ └─┬ lib
  62K   │ │   └── computed
 114K   │ ├─┬ template-compiler
 109K   │ │ └─┬ lib
  20K   │ │   ├── plugins
 4.6K   │ │   ├── system
 4.1K   │ │   └── -internal
  66K   │ ├─┬ application
 5.6K   │ │ └── lib
  52K   │ ├─┬ debug
  21K   │ │ └── lib
  38K   │ ├─┬ array
 4.9K   │ │ └── lib
  31K   │ ├─┬ engine
 4.7K   │ │ └── lib
  27K   │ ├── runloop
  22K   │ ├─┬ utils
  18K   │ │ └── lib
  20K   │ ├── helper
  11K   │ ├── destroyable
 9.8K   │ ├── instrumentation
 9.4K   │ ├── controller
 7.4K   │ ├── service
 7.2K   │ ├── owner
 6.2K   │ ├── component
 5.6K   │ ├── canary-features
 5.5K   │ ├── modifier
 5.1K   │ ├── template-compilation
 5.0K   │ ├── enumerable
 5.0K   │ ├── test
 4.4K   │ ├── template
 4.4K   │ ├── renderer
 4.2K   │ ├── deprecated-features
 4.1K   │ ├── template-factory
 4.1K   │ └── version
 709K   ├── shared-chunks
 384K   ├─┬ @glimmer
 166K   │ ├── runtime
  60K   │ ├── opcode-compiler
  30K   │ ├── manager
  22K   │ ├── validator
  14K   │ ├── program
  12K   │ ├── reference
  11K   │ ├── destroyable
  10K   │ ├─┬ tracking
 4.4K   │ │ └── primitives
  10K   │ ├── util
 8.1K   │ ├── node
 7.3K   │ ├── global-context
 6.4K   │ ├── wire-format
 5.0K   │ ├── vm
 4.9K   │ ├── encoder
 4.6K   │ ├── owner
 4.1K   │ └── env
  60K   ├─┬ ember-testing
  56K   │ └─┬ lib
  14K   │   ├── test
  14K   │   ├── helpers
  10K   │   ├── ext
 6.5K   │   └── adapters
  31K   ├── backburner.js
  25K   ├── ember
  24K   ├── route-recognizer
  18K   ├─┬ @simple-dom
  14K   │ └── document
 9.2K   ├── dag-map
 4.3K   ├── rsvp
 4.3K   └── router_js

kategengler · 2025-03-31T19:53:05Z

@NullVoxPopuli Why would this PR increase the size of shared-chunks by 19K?

NullVoxPopuli · 2025-03-31T20:17:05Z

it might not be rebased -- like main could have some other deprecation removed that is still present in this branch?

kategengler · 2025-03-31T20:26:28Z

@NullVoxPopuli ah I see -- wonder if we should gate the size comment on the PR being up-to-date?

NullVoxPopuli · 2025-03-31T20:29:25Z

Since Ci/Tests run with an ephemeral "what would be if the PR were merged" branch, is there a way we can get that ref and use that?

kategengler · 2025-03-31T20:38:31Z

Since Ci/Tests run with an ephemeral "what would be if the PR were merged" branch, is there a way we can get that ref and use that?

hm, github.ref should already be that on pull_request...

…jr/ember.js into clean-up-component-template-resolving

kategengler · 2025-04-01T17:13:56Z

@tcjr I think something has gone wrong here -- it is showing files as new that already exist 🤔

tcjr · 2025-04-01T18:09:17Z

@tcjr I think something has gone wrong here -- it is showing files as new that already exist 🤔
Fouled up this branch. Gonna make a clean PR.

tcjr added 3 commits March 22, 2025 10:14

Removed tests targeting DEPRECATE_COMPONENT_TEMPLATE_RESOLVING

1e7df29

Updated code for removal of DEPRECATE_COMPONENT_TEMPLATE_RESOLVING

ca6fdc6

Removed DEPRECATE_COMPONENT_TEMPLATE_RESOLVING

fdc15a0

tcjr changed the title ~~Clean up DEPRECATE_COMPONENT_TEMPLATE_RESOLVING~~ [CLEANUP] Remove DEPRECATE_COMPONENT_TEMPLATE_RESOLVING Mar 22, 2025

kategengler reviewed Mar 24, 2025

View reviewed changes

NullVoxPopuli and others added 7 commits March 25, 2025 11:33

Fix size PR workflow

a0e0fb1

Merge pull request emberjs#20885 from NullVoxPopuli/fix-size-pr-workflow

ffd5c17

Fix size PR workflow

Fix size comment workflow

41b0f85

Merge pull request emberjs#20886 from NullVoxPopuli/fix-size-pr-workflow

8548d45

Fix size comment workflow

add diff to gh action size (emberjs#20889)

aedf988

* Diff dev assets * Add diff to size action * Fix diff * Fix diff * Update size * Demo * hm * hm * hm * hm * hm * hm * hm * hm * Revert "Demo" This reverts commit c520b6f.

NullVoxPopuli reviewed Mar 27, 2025

View reviewed changes

tcjr and others added 2 commits March 28, 2025 09:22

Restored tests previously gated via deprecation

869001b

tcjr added 7 commits April 1, 2025 10:15

Fixed template for test

ea22295

Removed tests targeting DEPRECATE_COMPONENT_TEMPLATE_RESOLVING

ea7f84b

Updated code for removal of DEPRECATE_COMPONENT_TEMPLATE_RESOLVING

e5d859b

Removed DEPRECATE_COMPONENT_TEMPLATE_RESOLVING

2df485f

Restored tests previously gated via deprecation

9889314

Fixed template for test

1fca15b

Merge branch 'clean-up-component-template-resolving' of github.com:tc…

5322d7f

…jr/ember.js into clean-up-component-template-resolving

tcjr closed this Apr 1, 2025

Uh oh!

[CLEANUP] Remove DEPRECATE_COMPONENT_TEMPLATE_RESOLVING #20881

[CLEANUP] Remove DEPRECATE_COMPONENT_TEMPLATE_RESOLVING #20881

Uh oh!

Conversation

tcjr commented Mar 22, 2025

Uh oh!

kategengler Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

NullVoxPopuli Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

kategengler Mar 27, 2025

Choose a reason for hiding this comment

Uh oh!

NullVoxPopuli Mar 27, 2025

Choose a reason for hiding this comment

Uh oh!

tcjr Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kategengler commented Mar 31, 2025

Uh oh!

NullVoxPopuli commented Mar 31, 2025

Uh oh!

kategengler commented Mar 31, 2025

Uh oh!

NullVoxPopuli commented Mar 31, 2025

Uh oh!

kategengler commented Mar 31, 2025

Uh oh!

kategengler commented Apr 1, 2025

Uh oh!

tcjr commented Apr 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Mar 31, 2025 •

edited

Loading