Cleanup benchmark code#21060
Merged
NullVoxPopuli merged 1 commit intomainfrom Jan 20, 2026
Merged
Conversation
NullVoxPopuli
commented
Jan 17, 2026
| } | ||
| } | ||
|
|
||
| process.on('exit', cleanup); |
Contributor
Author
There was a problem hiding this comment.
cleanup handlers can't be async, so I moved the cleanup into a try-finally.
It doesn't allow us to capture Control+C, but 🤷 seems low stakes
Contributor
Estimated Asset SizesDiff Details
|
NullVoxPopuli
commented
Jan 17, 2026
| reuse: REUSE, | ||
| }); | ||
|
|
||
| console.log(`\nWrote report: ${result.msgFile}`); |
Contributor
Author
There was a problem hiding this comment.
this output was useless, here is the tracerbench output
driesdl
approved these changes
Jan 17, 2026
|
|
||
| await cleanup(); | ||
|
|
||
| return { |
There was a problem hiding this comment.
No other functions that depend on the return value of runBenchmark?
Contributor
Author
There was a problem hiding this comment.
the primary output is via the CLI's stdout, and then the output reports
| } | ||
|
|
||
| process.on('exit', cleanup); | ||
| process.on('SIGINT', () => { |
There was a problem hiding this comment.
Is this okay to be removed? When users do ctrl c to exit?
Contributor
Author
There was a problem hiding this comment.
I don't know how to synchronously kill servers -- which like.. I guess I could do with spawnSync / execSync, but that then needs a lot more code to gracefully handle exceptions, stdio/etc.
these event handlers can't be async, so that's why I removed the code -- it's likely they weren't working anyway
ef4
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.