Remove _globalsMode and _prepareForGlobalsMode from Application#21198
Merged
kategengler merged 2 commits intomainfrom Mar 6, 2026
Merged
Remove _globalsMode and _prepareForGlobalsMode from Application#21198kategengler merged 2 commits intomainfrom
_globalsMode and _prepareForGlobalsMode from Application#21198kategengler merged 2 commits intomainfrom
Conversation
Co-authored-by: kategengler <444218+kategengler@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove _globalsMode and _prepareForGlobalsMode from codebase
Remove Mar 6, 2026
_globalsMode and _prepareForGlobalsMode from Application
Contributor
📊 Package size report -0.1%↓
🤖 This report was automatically generated by pkg-size-action |
| as a global namespace. See the docs on the `_globalsMode` property | ||
| for details. | ||
|
|
||
| Most of these features are already deprecated in 1.x, so we can |
NullVoxPopuli
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_globalsModewas always coerced to equalautoboot(this.autoboot = this._globalsMode = Boolean(this.autoboot)), making it a redundant alias. This removes both the property and its associated setup method.Changes
_globalsModeproperty declaration and JSDoc_prepareForGlobalsMode()method; its body (Router subclass creation +_buildDeprecatedInstance()) is inlined directly into theif (this.autoboot)block ininit()reset()assertion — dropped the redundantthis._globalsMode &&conditiondidBecomeReady()— removed the deadelsebranch that built a new instance (was explicitly noted as unreachable since_globalsMode === autobootwas enforced)tests/docs/expected.jsto remove both entries from the documented classitems list💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.