Add pnpm patches for ember-cli and @embroider/compat #21262
Merged
NullVoxPopuli merged 4 commits intoemberjs:nvp/v7-testfrom Mar 28, 2026
Merged
Add pnpm patches for ember-cli and @embroider/compat #21262NullVoxPopuli merged 4 commits intoemberjs:nvp/v7-testfrom
NullVoxPopuli merged 4 commits intoemberjs:nvp/v7-testfrom
Conversation
Patches ember-cli@6.11.0 (ember-cli/ember-cli#10971) and @embroider/compat@4.1.16 (embroider-build/embroider#2695) to handle ember-source no longer exporting `paths` in v7. - ember-cli: guard `_initVendorFiles` against missing `paths` - @embroider/compat: skip legacy vendor file creation when `paths` absent Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NullVoxPopuli-ai-agent
force-pushed
the
fix-smoke-test-patches
branch
from
38146d5 to
9c5134c
Compare
NullVoxPopuli
changed the title
- Patch ember-cli-htmlbars@7.0.0 to handle missing absolutePaths in v7 ember-source, falling back to the ESM template compiler path. - Update sourcemap-test.js for v7's ESM-only dist structure (dist/ember.debug.js no longer exists). - Include template-compiler-test.js fix for ESM imports. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NullVoxPopuli-ai-agent
force-pushed
the
fix-smoke-test-patches
branch
from
7175f04 to
a3988bf
Compare
The v7 build outputs to dist/dev/packages/ and dist/prod/packages/, not dist/packages/. The template compiler fallback path must use the dev directory. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ember-auto-import also accesses emberSource.absolutePaths.templateCompiler for babel template compilation config. Add the same fallback to the dist/dev/ ESM template compiler path for v7. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds pnpm patches so the v7 smoke tests can pass without waiting for upstream releases:
ember-cli@6.11.0 (Support ember-source (ESM) -- without addon vendor paths ember-cli/ember-cli#10971): Guards
_initVendorFilesagainstemberSource.pathsbeing undefined. Without this, all classic and embroider builds crash withCannot read properties of undefined (reading 'debug').@embroider/compat@4.1.16 (Conditional file writes for Ember modules embroider-build/embroider#2695): Skips legacy vendor file creation (
ember.js,ember-testing.js,ember-template-compiler.js) whenemberSource.pathsis absent. Without this, embroider builds fail trying to readdist/ember-template-compiler.jswhich no longer exists.These patches can be removed once the upstream PRs are released.
Test plan
classicUseModulesFeature-basics)embroiderWebpack-basics)embroiderVite-basics)🤖 Generated with Claude Code