compare url attribute names case-insensitively when sanitizing#21430
Closed
rootvector2 wants to merge 1 commit into
Closed
compare url attribute names case-insensitively when sanitizing#21430rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
checkURI and checkDataURI matched attribute names against the lowercase badAttributes lists with a strict comparison, so a mixed-case name such as HREF or SRC bypassed the javascript:/vbscript: protocol check even though requiresSanitization still routed the element through the sanitizer.
Contributor
|
I rebased over here: #21434 thank you!!! <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkURI and checkDataURI test the attribute name against the lowercase badAttributes lists with a strict match, so an upper- or mixed-case name like HREF or SRC never matches and the javascript:/vbscript: check in sanitizeAttributeValue is skipped. Attribute names are case-insensitive in HTML, and requiresSanitization already routes these elements through the sanitizer via the lowercased property name, so the value reaches the DOM unsanitized. Lower-case the name in both checks so mixed-case url attributes sanitize the same as lowercase ones.