mark data: urls as unsafe on iframe[src] and object[data]#21441
Closed
rootvector2 wants to merge 1 commit into
Closed
mark data: urls as unsafe on iframe[src] and object[data]#21441rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The URL sanitizer only neutralizes
data:URLs on<embed src>.<iframe src>and<object data>also load their URL as a nested document, sodata:text/html,<script>…</script>is rendered and runs script. For iframe the value reachessanitizeAttributeValuebut onlyjavascript:/vbscript:are rejected; for objectrequiresSanitizationreturns false and the value is written raw.The new
checkDataProtocolpath rejectsdata:(andjavascript:/vbscript:) for those two tags while leaving normal http(s) and relative URLs alone, so legitimate iframes and objects keep working. Repro on https://limber.glimdown.com renders the script for an<object data={{this.url}}>bound to adata:text/htmlvalue.