Skip to content

Fix issue #2 - SC.Buttons inside of form tags trigger form submission #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ebryn wants to merge 2 commits into from
Closed

Fix issue #2 - SC.Buttons inside of form tags trigger form submission #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fa79bc
Alter SC.Button mouseUp event to return false to avoid form submissions.
ebryn May 26, 2011
9eab4f2
Typo in sproutcore-metal docs
ebryn Jun 2, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/sproutcore-handlebars/lib/controls/button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ SC.Button = SC.View.extend({

this._mouseDown = false;
this._mouseEntered = false;
return false;
},

// TODO: Handle proper touch behavior. Including should make inactive when
Expand Down
2 changes: 1 addition & 1 deletion packages/sproutcore-metal/docs/NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ notifications and other actions. In order to do this it relies on a newer
feature in JavaScript environments called __getters and setters__.

All browsers in common usage support getters and setters except for IE7 and 8.
In particular, all mobile browsers support the, which is why we think now is
In particular, all mobile browsers support them, which is why we think now is
the time to start to use them.

If you need to support IE7 and 8 however, you cannot rely on the getter and
Expand Down