Removes duplicate SC.isArray implementation from sproutcore-runtime.#48
Merged
tomdale merged 1 commit intoemberjs:masterfrom Jun 28, 2011
trek:RemoveDuplicateIsArray
Merged
Removes duplicate SC.isArray implementation from sproutcore-runtime.#48tomdale merged 1 commit intoemberjs:masterfrom trek:RemoveDuplicateIsArray
tomdale merged 1 commit intoemberjs:masterfrom
trek:RemoveDuplicateIsArray
Conversation
runtime depends on metal, where SC.isArray is also defined. Higher level libraries in the framework also require metal.
tomdale
pushed a commit
that referenced
this pull request
Jun 28, 2011
Removes duplicate SC.isArray implementation from sproutcore-runtime.
bmac
pushed a commit
to bmac/ember.js
that referenced
this pull request
Aug 18, 2013
…al/lib/binding Remove the Binding.to and Binding.from docs strings that where shadowing...
locks
added a commit
that referenced
this pull request
Jul 31, 2017
So, this is kind of a fun one. From what I can tell, `ControllerContentModelAliasDeprecation` was introduced, due to Controllers having a `content` property, which`model` was aliased to. This was done because `ObjectController` and `ArrayController` were proxying controllers. But, in Ember, routes set up the `model` property of its respective controller. What this meant is that if someone declared a `content` property in their controller, `model` would—seemingly unrelated—break,hence the `ControllerContentModelAliasDeprecation` mixin. Nowadays it is fine to override `content` because the source of truth was reverse, and `model` is now the primary property, being `content` the alias. It is, then, time to remove the old deprecation and instead deprecate the alias itself, so that in the future users can define a `content` property in their controllers if they so desire. Another API bites the dust. Here's to removing yet more code in the future, and make Ember sparkle-clean. ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ 1 change; before #48 8 seconds ago
sandstrom
pushed a commit
to sandstrom/ember.js
that referenced
this pull request
Jun 17, 2021
mansona
pushed a commit
to mansona/ember.js
that referenced
this pull request
Mar 10, 2026
Closes emberjs#43 Closes emberjs#44 Closes emberjs#48 Thanks to @KidkArolis for pointing out the issue and providing the test case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runtime depends on metal, where SC.isArray is also defined. Higher level libraries in the framework also
require metal.