Reduce the number of test runs on Travis#56
Merged
ryanto merged 2 commits intoembermap:masterfrom Jun 21, 2019
Merged
Conversation
Member
|
Thanks! I think this is a good change to make. Travis is also slow, so I'd like to see what the test times are without these scenarios. |
Collaborator
Author
|
We probably should also merge build stages, either all into a single one, or at least "Additional tests" and "Versioned tests". There's no need to wait for "floating dependencies" scenario to finish before starting versioned scenarios. |
Member
|
Yup, I think merging Additional and Versioned sounds like a good idea. Do you want to do that with this PR or another? |
* `fastboot-1.2`: was essentially the same as `ember-lts-3.8` because `fastboot` in package.json is already using `^1.2.1` * `ember-default`: was the same as `stage: test` * `ember-lts-2.12`, `ember-lts-2.16`: seems reasonable to limit ember 2.x tests to the oldest supported and the latest LTS versions
Collaborator
Author
|
I've updated this PR. Btw. the "deploy" stage is failing: https://travis-ci.org/embermap/ember-cli-fastboot-testing/jobs/547998598 |
Member
|
Ok awesome! I'll take a look at the deploy phase in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMO Travis takes way too long to complete all tests for a PR, e.g.
"Ran for 34 min 15 sec
Total time 56 min 55 sec"
I believe we could cut some of the ember-try scenarios:
fastboot-1.2: was essentially the same asember-lts-3.8becausefastbootin package.json is already using^1.2.1ember-default: was the same asstage: testember-lts-2.12,ember-lts-2.16: seems reasonable to limit ember 2.x tests to the oldest supported and the latest LTS versions