Skip to content

New article: Installing Maven-style Embulk plugins#25

Merged
dmikurube merged 1 commit intomainfrom
article-installing-maven-style-embulk-plugins
Jun 13, 2024
Merged

New article: Installing Maven-style Embulk plugins#25
dmikurube merged 1 commit intomainfrom
article-installing-maven-style-embulk-plugins

Conversation

@dmikurube
Copy link
Copy Markdown
Member

No description provided.

@dmikurube dmikurube requested a review from a team as a code owner June 13, 2024 08:16
Copy link
Copy Markdown
Member

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍


repositories {
mavenCentral()
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Q] Is this syntax supports non Maven Central Repository?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I didn't know which one it meant

(1) java -jar embulk-0.11.3.jar -Xembulk_home=/tmp/foo install support Maven Central only, but build.gradle support non-Maven Central repository.
(2) Both syntax supports Maven Central only.

Adding comment would be clear.

repositories {
    // It now supports only Maven Central
    mavenCentral()
}

Anyway LGTM👍

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believed it's clear as this sentense is located in the "1: Embulk's built-in subcommand install" section...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// It now supports only Maven Central
mavenCentral()

At least, the Gradle plugin does not intend to support only Maven Central. It SHOULD work.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. thank you. It's cleared for me.


```
$ java -jar embulk-0.11.4.jar -Xembulk_home=/home/user/my-embulk-home run s3_with_maven.yml
2024-06-13 17:01:55.373 +0900 [INFO] (main): embulk_home is set from command-line: /home/user/my-embulk-home
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Above example used embulk-0.11.3. I thought Using the same Embulk version give a more unified look.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, maybe. Thanks! Let me update it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, I concluded that the current revision is okay. It's because:

  • The section 1 is about the feature introduced in v0.11.3, then using v0.11.3.
  • The section 2 is not about Embulk's built-in feature, then using just the latest one.

@dmikurube
Copy link
Copy Markdown
Member Author

Thanks!

@dmikurube dmikurube merged commit 8c938df into main Jun 13, 2024
@dmikurube dmikurube deleted the article-installing-maven-style-embulk-plugins branch June 13, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants