New article: Installing Maven-style Embulk plugins#25
Conversation
|
|
||
| repositories { | ||
| mavenCentral() | ||
| } |
There was a problem hiding this comment.
[Q] Is this syntax supports non Maven Central Repository?
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks! I didn't know which one it meant
(1) java -jar embulk-0.11.3.jar -Xembulk_home=/tmp/foo install support Maven Central only, but build.gradle support non-Maven Central repository.
(2) Both syntax supports Maven Central only.
Adding comment would be clear.
repositories {
// It now supports only Maven Central
mavenCentral()
}Anyway LGTM👍
There was a problem hiding this comment.
I believed it's clear as this sentense is located in the "1: Embulk's built-in subcommand install" section...
There was a problem hiding this comment.
// It now supports only Maven Central mavenCentral()
At least, the Gradle plugin does not intend to support only Maven Central. It SHOULD work.
There was a problem hiding this comment.
I see. thank you. It's cleared for me.
|
|
||
| ``` | ||
| $ java -jar embulk-0.11.4.jar -Xembulk_home=/home/user/my-embulk-home run s3_with_maven.yml | ||
| 2024-06-13 17:01:55.373 +0900 [INFO] (main): embulk_home is set from command-line: /home/user/my-embulk-home |
There was a problem hiding this comment.
Minor: Above example used embulk-0.11.3. I thought Using the same Embulk version give a more unified look.
There was a problem hiding this comment.
Ah, maybe. Thanks! Let me update it.
There was a problem hiding this comment.
Finally, I concluded that the current revision is okay. It's because:
- The section 1 is about the feature introduced in v0.11.3, then using v0.11.3.
- The section 2 is not about Embulk's built-in feature, then using just the latest one.
|
Thanks! |
No description provided.