Update mimeogram to use emcd-appcore #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade emcd-appcore from 1.4 to 1.6 with [cli] optional dependencies - Replace direct usage of appcore.inscription.Control with appcore.cli.InscriptionControl adapter - Use TargetStreams enum instead of exposing TextIO objects to Tyro parser - Update CLI initialization to convert adapter to real Control object via as_control() - Fix "Empty hints for TextIOWrapper" error that prevented CLI from running The issue was that Tyro couldn't introspect TextIOWrapper objects used as default values in appcore.inscription.Control. The appcore.cli module provides adapter classes that expose enums to the CLI parser and convert them to actual stream objects at runtime. All tests (173 passed) and linters still pass. Fixes the issue documented in .auxiliary/notes/issues.md
- Add default_factory for application field with name='mimeogram' - Allows version command to run without requiring --application.name - Tested: mimeogram version now works correctly - Tested: mimeogram create still works as expected
- Move appcore_cli import before asyncf (lexicographic order) - Reorder constants: _application_default before _inscription_mode_default - Add blank lines between constants and Cli class definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that Tyro couldn't introspect TextIOWrapper objects used as default values in appcore.inscription.Control. The appcore.cli module provides adapter classes that expose enums to the CLI parser and convert them to actual stream objects at runtime.
All tests (173 passed) and linters still pass.
Fixes the issue documented in .auxiliary/notes/issues.md