Skip to content

fix: magic links missing root prefix#133

Merged
ascorbic merged 4 commits intoemdash-cms:mainfrom
kyjus25:bug/magic-links
Apr 4, 2026
Merged

fix: magic links missing root prefix#133
ascorbic merged 4 commits intoemdash-cms:mainfrom
kyjus25:bug/magic-links

Conversation

@kyjus25
Copy link
Copy Markdown
Contributor

@kyjus25 kyjus25 commented Apr 2, 2026

What does this PR do?

Closes #128

Magic link (and various other auth touchpoints) were missing the /_emdash/ prefix

Type of change

  • Bug fix
  • Feature (requires approved Discussion)
  • Refactor (no behavior change)
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • I have read CONTRIBUTING.md
  • pnpm typecheck passes
  • pnpm --silent lint:json | jq '.diagnostics | length' returns 0
  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • New features link to an approved Discussion: https://github.com/emdash-cms/emdash/discussions/...

AI-generated code disclosure

  • This PR includes AI-generated code

Screenshots / test output

➜  emdash git:(bug/magic-links) pnpm exec vitest run packages/core/tests/unit/auth/invite.test.ts packages/core/tests/unit/auth/signup.test.ts packages/core/tests/unit/auth/magic-link.test.ts


 RUN  v4.1.2 /Users/kyjus25/Documents/testing/emdash

 ✓ packages/core/tests/unit/auth/magic-link.test.ts (1 test) 22ms
 ✓ packages/core/tests/unit/auth/invite.test.ts (16 tests) 138ms
 ✓ packages/core/tests/unit/auth/signup.test.ts (21 tests) 880ms

 Test Files  3 passed (3)
      Tests  38 passed (38)
   Start at  15:17:41
   Duration  1.31s (transform 405ms, setup 0ms, import 1.09s, tests 1.04s, environment 0ms)

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 2, 2026

🦋 Changeset detected

Latest commit: a10b7d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@emdash-cms/auth Patch
emdash Patch
@emdash-cms/cloudflare Patch
@emdash-cms/plugin-ai-moderation Patch
@emdash-cms/plugin-atproto Patch
@emdash-cms/plugin-audit-log Patch
@emdash-cms/plugin-color Patch
@emdash-cms/plugin-embeds Patch
@emdash-cms/plugin-forms Patch
@emdash-cms/plugin-webhook-notifier Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@kyjus25 kyjus25 changed the title Fix magic links fix: magic links missing root prefix Apr 2, 2026
@kyjus25
Copy link
Copy Markdown
Contributor Author

kyjus25 commented Apr 2, 2026

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Apr 2, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 2, 2026

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@133

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@133

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@133

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@133

emdash

npm i https://pkg.pr.new/emdash@133

create-emdash

npm i https://pkg.pr.new/create-emdash@133

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@133

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@133

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@133

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@133

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@133

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@133

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@133

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@133

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@133

commit: a10b7d6

@ascorbic ascorbic merged commit 9269759 into emdash-cms:main Apr 4, 2026
20 checks passed
@emdashbot emdashbot bot mentioned this pull request Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sign to emdash admin via email doesn't work - 404

2 participants