fix: magic links missing root prefix#133
Merged
ascorbic merged 4 commits intoemdash-cms:mainfrom Apr 4, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: a10b7d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #128
Magic link (and various other auth touchpoints) were missing the
/_emdash/prefixType of change
Checklist
pnpm typecheckpassespnpm --silent lint:json | jq '.diagnostics | length'returns 0pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure
Screenshots / test output
➜ emdash git:(bug/magic-links) pnpm exec vitest run packages/core/tests/unit/auth/invite.test.ts packages/core/tests/unit/auth/signup.test.ts packages/core/tests/unit/auth/magic-link.test.ts RUN v4.1.2 /Users/kyjus25/Documents/testing/emdash ✓ packages/core/tests/unit/auth/magic-link.test.ts (1 test) 22ms ✓ packages/core/tests/unit/auth/invite.test.ts (16 tests) 138ms ✓ packages/core/tests/unit/auth/signup.test.ts (21 tests) 880ms Test Files 3 passed (3) Tests 38 passed (38) Start at 15:17:41 Duration 1.31s (transform 405ms, setup 0ms, import 1.09s, tests 1.04s, environment 0ms)