Conversation
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
Miniflare asserts database_id is truthy. An empty string crashes on startup. Use 'local' as a placeholder -- miniflare doesn't validate it for local dev, and the comment tells users to replace it with a real ID for deploy.
travisbreaks
pushed a commit
to travisbreaks/emdash
that referenced
this pull request
Apr 5, 2026
…timizedeps fix: exclude virtual:emdash from optimizeDeps to fix npm installs on Cloudflare
jdevalk
added a commit
to jdevalk/emdash
that referenced
this pull request
Apr 7, 2026
- Fix emdash-cms#1: Use @phosphor-icons/react instead of lucide-react - Fix emdash-cms#2: Send minimal patch { image } instead of spreading stale seo props - Fix emdash-cms#3: Only show OG Image next to the featured_image field, not all image fields - Fix emdash-cms#4: Only add description text for the featured_image field - Fix emdash-cms#5: Add responsive breakpoint (grid-cols-1 md:grid-cols-2) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ascorbic
added a commit
that referenced
this pull request
Apr 7, 2026
* Add OG Image field to content editor The `_emdash_seo` table and content API already support `seo_image`, but the admin UI had no way to set it. This adds: - `SeoImageField` component using the existing `MediaPickerModal` - 2-column grid layout placing the OG Image next to the Featured Image - `description` prop on `ImageFieldRenderer` for helper text below images - Preserve `seo.image` in `SeoPanel.emitChange` so sidebar edits don't clear the image Closes #327 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * style: format * Add changeset and fix stale seo.image in SeoPanel - Add changeset for @emdash-cms/admin patch release - Remove image from SeoPanel.emitChange to avoid overwriting a freshly-selected OG image with a stale prop value Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Address review feedback on OG Image field - Fix #1: Use @phosphor-icons/react instead of lucide-react - Fix #2: Send minimal patch { image } instead of spreading stale seo props - Fix #3: Only show OG Image next to the featured_image field, not all image fields - Fix #4: Only add description text for the featured_image field - Fix #5: Add responsive breakpoint (grid-cols-1 md:grid-cols-2) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * style: format --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: emdashbot[bot] <emdashbot[bot]@users.noreply.github.com> Co-authored-by: Matt Kane <mkane@cloudflare.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Could not resolve "virtual:emdash/*"errors whenemdashis installed from npm (not workspace link) on Cloudflare"virtual:emdash"tooptimizeDeps.excludein bothssr.optimizeDeps(Cloudflare) and rootoptimizeDepsProblem
When
emdashis installed from npm, the dist files contain externalizedvirtual:emdash/*import specifiers (e.g.import("virtual:emdash/seed")). These are intentionally left as bare specifiers by tsdown -- they're resolved by the Vite virtual module plugin at the user's site build/dev time.However, Vite's esbuild-based dependency pre-bundler (
optimizeDeps) crawlsemdash's dist files when pre-bundling its dependencies (theemdash > kysely,emdash > jose, etc. entries). During this crawl, esbuild encounters thevirtual:emdash/*imports and fails because it has no plugin to resolve them.In the monorepo this doesn't happen because
emdashresolves to the workspace source, where Vite processes files through its transform pipeline (which includes the virtual module plugin) rather than through esbuild's pre-bundler.The
@astrojs/cloudflareadapter already excludes Astro's own virtual modules (astro:*,virtual:astro:*) from the optimizer, butvirtual:emdashwasn't listed.How it works
Vite's
optimizeDeps.excludematching uses prefix comparison:id.startsWith(entry + "/"). So"virtual:emdash"matches all"virtual:emdash/config","virtual:emdash/seed","virtual:emdash/dialect", etc.