Skip to content

Fix page metadata titles without the site-name suffix#209

Open
JonahFoster wants to merge 1 commit intoemdash-cms:mainfrom
JonahFoster:fix/og-title-page-title
Open

Fix page metadata titles without the site-name suffix#209
JonahFoster wants to merge 1 commit intoemdash-cms:mainfrom
JonahFoster:fix/og-title-page-title

Conversation

@JonahFoster
Copy link
Copy Markdown
Contributor

@JonahFoster JonahFoster commented Apr 4, 2026

What does this PR do?

Fixes shared page metadata title handling so Open Graph, Twitter, and article JSON-LD can use a page-specific title without inheriting the site-name suffix from the document <title>.

Closes #168

Type of change

  • Bug fix
  • Feature (requires approved Discussion)
  • Refactor (no behavior change)
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • I have read CONTRIBUTING.md
  • pnpm typecheck passes
  • pnpm --silent lint:json | jq '.diagnostics | length' returns 0
  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • I have added a changeset (if this PR changes a published package)
  • New features link to an approved Discussion: https://github.com/emdash-cms/emdash/discussions/...

AI-generated code disclosure

  • This PR includes AI-generated code

Screenshots / test output

Behavior check:

  • Site name remains in the document <title>
  • og:title uses the page title without the site-name suffix
Site name is visible in the title tag but not in the meta og:title tag

Validation run:

  • pnpm typecheck passed
  • pnpm typecheck:demos passed
  • pnpm typecheck:templates passed
  • pnpm test passed
  • pnpm format run
  • pnpm --silent lint:json | jq '.diagnostics | length' returned 0

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 4, 2026

🦋 Changeset detected

Latest commit: 96c1835

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
emdash Patch
@emdash-cms/cloudflare Patch
@emdash-cms/plugin-ai-moderation Patch
@emdash-cms/plugin-atproto Patch
@emdash-cms/plugin-audit-log Patch
@emdash-cms/plugin-color Patch
@emdash-cms/plugin-embeds Patch
@emdash-cms/plugin-forms Patch
@emdash-cms/plugin-webhook-notifier Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

Overlapping PRs

This PR modifies files that are also changed by other open PRs:

This may cause merge conflicts or duplicated work. A maintainer will coordinate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

og:title in base SEO contributions includes site name

1 participant