fix(create-emdash): add blank template to Cloudflare picker#257
Open
travisbreaks wants to merge 1 commit intoemdash-cms:mainfrom
Open
fix(create-emdash): add blank template to Cloudflare picker#257travisbreaks wants to merge 1 commit intoemdash-cms:mainfrom
travisbreaks wants to merge 1 commit intoemdash-cms:mainfrom
Conversation
The blank template was available for Node.js but missing from the Cloudflare Workers template list in `npm create emdash`. This adds the blank-cloudflare template variant and registers it in the CLI, the sync script, and the changeset ignore list. Fixes emdash-cms#238 Co-Authored-By: Tadao <tadao@travisfixes.com>
🦋 Changeset detectedLatest commit: 19284bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Overlapping PRsThis PR modifies files that are also changed by other open PRs:
This may cause merge conflicts or duplicated work. A maintainer will coordinate. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
blanktemplate was listed inNODE_TEMPLATESbut missing fromCLOUDFLARE_TEMPLATESin thecreate-emdashCLI. Since the CLI defaults to Cloudflare Workers, most users never saw the blank option in the template picker.This adds the
blank-cloudflaretemplate variant (following the same pattern as blog-cloudflare, starter-cloudflare, etc.) and registers it across the CLI, sync script, and changeset config.Closes #238
Type of change
Checklist
pnpm typecheckpassespnpm --silent lint:json | jq '.diagnostics | length'returns 0pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure
Changes
templates/blank-cloudflare/with Cloudflare-specificpackage.json,astro.config.mjs, andwrangler.jsonc(matching the pattern of other-cloudflarevariants)blankentry toCLOUDFLARE_TEMPLATESinpackages/create-emdash/src/index.tsblank:blank-cloudflarepair toscripts/sync-cloudflare-templates.sh@emdash-cms/template-blank-cloudflareto changeset ignore listcreate-emdashNote
The
emdash-cms/templatesrepo will also need ablank-cloudflaredirectory for the CLI download to work at runtime. This PR covers the monorepo side; the templates repo sync may need a separate update.