fix(plugins): handle standalone wildcard in allowedHosts#338
Merged
ascorbic merged 4 commits intoemdash-cms:mainfrom Apr 11, 2026
Merged
fix(plugins): handle standalone wildcard in allowedHosts#338ascorbic merged 4 commits intoemdash-cms:mainfrom
ascorbic merged 4 commits intoemdash-cms:mainfrom
Conversation
When a plugin declares allowedHosts: ["*"], the isHostAllowed() function now returns true for all hosts. Previously, standalone "*" fell through to a literal equality check (host === "*") which never matched. Fixes emdash-cms#278
🦋 Changeset detectedLatest commit: bc688d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #278
The
isHostAllowed()function inpackages/core/src/plugins/context.tsonly handles*.domainpatterns (e.g.*.example.com). When a plugin declaresallowedHosts: ["*"], the standalone"*"doesn't matchstartsWith("*.")and falls through to a literal equality check (host === "*"), which never matches any real hostname.The fix adds an early return for
pattern === "*"before the subdomain wildcard check.Type of change
Checklist
pnpm typecheckpassespnpm --silent lint:json | jq '.diagnostics | length'returns 0pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure
This contribution was developed with AI assistance (Codex).