Add Back navigation to Security and Domain settings pages#45
Add Back navigation to Security and Domain settings pages#45ascorbic merged 4 commits intoemdash-cms:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 122fe0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
@Flynsarmy could you add a changeset please. See https://github.com/emdash-cms/emdash/blob/main/CONTRIBUTING.md#changesets |
|
looks good! @ascorbic could you add this changeset? |
There was a problem hiding this comment.
Pull request overview
Adds consistent “Back to settings” navigation (left arrow + title header) to the Security Settings and Self-Signup Domains admin pages, aligning them with other settings sub-pages.
Changes:
- Introduced a shared header block (
settingsHeader) in both pages and reused it across loading/error/normal states. - Removed the old “Back to Settings” outline button from the external-auth informational state (replaced by the new header back arrow).
- Added a changeset bump for
@emdash-cms/admin.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/admin/src/components/settings/SecuritySettings.tsx | Adds reusable header with back arrow; adjusts status banner styles; modifies error-state container styling. |
| packages/admin/src/components/settings/AllowedDomainsSettings.tsx | Adds reusable header with back arrow; adjusts status banner styles; modifies error-state container styling. |
| .changeset/tidy-chairs-itch.md | Patch changeset for the admin package. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <h1 className="text-2xl font-bold">Security Settings</h1> | ||
| <div className="rounded-lg border border-kumo-danger/50 bg-kumo-danger/10 p-6"> | ||
| {settingsHeader} | ||
| <div className="rounded-lg border bg-kumo-base p-6"> |
There was a problem hiding this comment.
The load-error state styling was changed from a dedicated danger container (danger border + tinted background) to a normal card with only red text. This makes the error state much less visible and is inconsistent with other admin error panels (e.g. ApiTokenSettings uses border-kumo-danger/50 bg-kumo-danger/10). Consider restoring the previous error container classes (or using the shared error panel style used elsewhere) so errors are clearly distinguished from normal content.
| <div className="rounded-lg border bg-kumo-base p-6"> | |
| <div className="rounded-lg border border-kumo-danger/50 bg-kumo-danger/10 p-6"> |
| <h1 className="text-2xl font-bold">Self-Signup Domains</h1> | ||
| <div className="rounded-lg border border-kumo-danger/50 bg-kumo-danger/10 p-6"> | ||
| {settingsHeader} | ||
| <div className="rounded-lg border bg-kumo-base p-6"> |
There was a problem hiding this comment.
The load-error state card no longer uses the standard danger styling (danger border + tinted background) and now renders as a normal bg-kumo-base panel with only red text. This reduces visibility and diverges from the error presentation used elsewhere in the admin (e.g. ApiTokenSettings / marketplace errors). Suggest restoring the previous danger container classes for the error state.
| <div className="rounded-lg border bg-kumo-base p-6"> | |
| <div className="rounded-lg border border-kumo-danger bg-kumo-danger/10 p-6"> |
|
Thanks to Nick Gray for sponsoring my time on this review :) |
|
Thanks for merging! PR was made before the PR templates were introduced so apologies for lack of changeset. |
This PR adds a Back arrow before the titles on Self-Signup Domains and Security Settings admin pages to make them consistent with all the other settings pages that already have the arrow.
Code was slopped up with Github Copilot.