fix(admin): add JSON field editor in content forms#489
Merged
ascorbic merged 2 commits intoemdash-cms:mainfrom Apr 14, 2026
Merged
fix(admin): add JSON field editor in content forms#489ascorbic merged 2 commits intoemdash-cms:mainfrom
ascorbic merged 2 commits intoemdash-cms:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 3809470 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ascorbic
reviewed
Apr 14, 2026
Collaborator
ascorbic
left a comment
ascorbic
left a comment
There was a problem hiding this comment.
Thanks! Just a couple of notes
The JSON field type had no dedicated case in the field renderer switch, so it fell through to the default text Input which rendered empty for object values. Adds a JsonFieldEditor component with a textarea, JSON.stringify for display, JSON.parse on change, and validation feedback. Closes emdash-cms#405 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Apply review feedback: parse/reformat JSON on blur instead of every keystroke, and use Lingui t`` for the "Invalid JSON" error message. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
all3f0r1
force-pushed
the
fix/json-field-editor-405
branch
from
e1487f6 to
3809470
Compare
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The JSON field type was selectable in the schema editor, but had no dedicated input renderer in the content editor. It fell through to the default text
Input, which rendered empty for object values sincetypeof value === "string"is false for objects.This adds a
JsonFieldEditorcomponent that:Closes #405
Type of change
Checklist
pnpm typecheckpassespnpm --silent lint:json | jq '.diagnostics | length'returns 0pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure
Screenshots / test output
Two new tests added in
ContentEditor.test.tsx:renders json fields as a textarea— verifies the JSON field renders a<textarea>elementrenders json fields with object values as formatted JSON— verifies object data is serialized as pretty-printed JSON