fix: repair invite flow — URL prefix + registration UI (fixes #67)#542
Merged
ascorbic merged 4 commits intoemdash-cms:mainfrom Apr 14, 2026
Merged
fix: repair invite flow — URL prefix + registration UI (fixes #67)#542ascorbic merged 4 commits intoemdash-cms:mainfrom
ascorbic merged 4 commits intoemdash-cms:mainfrom
Conversation
…test Fixes the two compounding bugs in the user invite system (Issue emdash-cms#67): - Bug 1: Invite URL drops /_emdash/ prefix. Fixed by pointing to admin UI page. - Bug 2: No UI to complete registration. Added InviteAcceptPage with passkey registration. - Bug 3 (from PR emdash-cms#81 review): Fixed failing test assertion to match new URL path. Based on PR emdash-cms#81 by @SrikanthAlva with the requested test fix applied. Closes emdash-cms#67
🦋 Changeset detectedLatest commit: e018395 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Scope checkThis PR changes 720 lines across 12 files. Large PRs are harder to review and more likely to be closed without review. If this scope is intentional, no action needed. A maintainer will review it. If not, please consider splitting this into smaller PRs. See CONTRIBUTING.md for contribution guidelines. |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
|
Yes please! We need this to work so we can onboard more users to our sites |
Contributor
Overlapping PRsThis PR modifies files that are also changed by other open PRs:
This may cause merge conflicts or duplicated work. A maintainer will coordinate. |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
ascorbic
reviewed
Apr 14, 2026
Collaborator
ascorbic
left a comment
ascorbic
left a comment
There was a problem hiding this comment.
Thanks! Just a few comments
packages/core/src/astro/routes/api/auth/invite/register-options.ts
Outdated
Show resolved
Hide resolved
…h, fix duplicate button, simplify email store
10 tasks
Collaborator
|
@mohamedmostafa58 Can you fix the e2e test failures? |
Making /_emdash/admin/signup a public server-side route allowed unauthenticated direct access. The signup page is only intended to be reached via client-side navigation from the login page. Made-with: Cursor
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the broken invite system (#67). Based on PR #81 by @SrikanthAlva with the failing test fix applied.
Closes #67